[website] Add content about the Sync plugin in the Material UI page by danilo-leal · Pull Request #40515 · mui/material-ui

danilo-leal · 2024-01-10T15:01:27Z

I have followed (at least) the PR section of the contributing guide.

This PR adds content about the Material UI Sync plugin to the Material UI and Design Kits pages.

mui-bot · 2024-01-10T15:03:52Z

Netlify deploy preview

https://deploy-preview-40515--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fe138b0

docs/src/components/productDesignKit/DesignKitFAQ.tsx

docs/src/components/productMaterial/MaterialDesignKits.tsx

Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

zanivan

It looks good! Just pushed a small fix for layout shift, and have a couple of remarks:

Here, I don't think we should have colorful icons, although I like them, it's not like this anywhere—so it's a bit odd to me.
The card layout is broken, cutting off the buttons

On a different note, I think it's worth changing the Design kits mentions to something broader, like “Design resources” or jut “Design”

danilo-leal · 2024-04-30T13:59:11Z

On a different note, I think it's worth changing the Design kits mentions to something broader, like “Design resources” or jut “Design”

@zanivan that makes sense, but there are some other related tasks (like fine-tuning the actual Design Kit description on the Store) that I'd find good to do before committing to this change. This design kit is very Material UI-centric, naturally, and we should go toward this clarity!

zanivan

Found one more issue, the focus style doesn't seem to be working properly here:

zanivan

Found a bug with the hover animation on the Design kit image:

Screen.Recording.2024-04-30.at.11.57.19.mov

zanivan

Design-wise looks good to me :)

…40515) Co-authored-by: David Cnoops <davidcnoops@outlook.com> Co-authored-by: zanivan <victorzanivan@gmail.com>

add content about MUI Connect on the Material + Design kits pages

39b9969

danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Jan 10, 2024

danilo-leal self-assigned this Jan 10, 2024

danilo-leal and others added 8 commits January 10, 2024 12:08

fix lint errors

60a6923

put Connect first

c3128bc

fixed incorrectly selected highlighter bug

6c3c210

avoid section height changing when switching between highlighters

8ffb6ab

MUI Connect signup form

18d6d91

fix lint

1ef1d71

mobile adjustments

8a85701

fine-tune adjustments

3a2172a

oliviertassinari reviewed Jan 13, 2024

View reviewed changes

docs/src/components/productDesignKit/DesignKitFAQ.tsx Outdated Show resolved Hide resolved

docs/src/components/productMaterial/MaterialDesignKits.tsx Show resolved Hide resolved

danilo-leal added 5 commits January 15, 2024 09:30

adjustments all around

d565123

trigger ci

7651ddb

change button label on the email component

ad99233

add standalone Connect page

df66bd7

play around with a different layout

1a96986

danilo-leal changed the title ~~[website] Add content about MUI Connect~~ [website] Add a Connect plug-in page Jan 18, 2024

danilo-leal added 3 commits January 17, 2024 22:42

continue iterating

cd4df95

refine the signup component styles

5301da1

Merge branch 'master' into add-connect-content-website

fde6b51

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 23, 2024

Merge branch 'master' into add-connect-content-website

d2494b8

Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 24, 2024

danilo-leal added 2 commits January 24, 2024 20:40

small wording adjustments

5fbed5c

de-emphasize email collection and focus on directing to Figma

71e32e0

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 29, 2024

Merge branch 'master' into add-connect-content-website

de4f115

Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 29, 2024

danilo-leal requested a review from zanivan April 29, 2024 21:19

danilo-leal added the needs cherry-pick The PR should be cherry-picked to master after merge. label Apr 29, 2024

danilo-leal and others added 2 commits April 29, 2024 18:21

remove old social preview image

d5dfd86

Fix layout shift

3788539

zanivan reviewed Apr 30, 2024

View reviewed changes

danilo-leal added 7 commits April 30, 2024 10:16

standardize layout

d4c7f3a

more style and writing standardization

77aa108

fix grid on the design kit demo section

e985061

design kits section: small tweak on the image width on mobile

650a35e

fix frame.demo container styles

963f026

remove redundant copy

b247a9e

iterate on copy

0468058

danilo-leal requested a review from zanivan April 30, 2024 13:59

zanivan reviewed Apr 30, 2024

View reviewed changes

danilo-leal added 2 commits April 30, 2024 11:16

customize the MaterialEnd section adding a "noFaq" prop

2bd7449

fix focus issue on the MaterialDesignKits section

ac26fe7

danilo-leal requested a review from zanivan April 30, 2024 14:22

zanivan reviewed Apr 30, 2024

View reviewed changes

danilo-leal added 2 commits April 30, 2024 12:59

organize components for better reuse and less duplication

88bcc12

fix MaterialDesignKits hover and reuse code

60981e9

danilo-leal requested a review from zanivan April 30, 2024 16:08

zanivan approved these changes Apr 30, 2024

View reviewed changes

fix product id order

fe138b0

danilo-leal enabled auto-merge (squash) April 30, 2024 19:34

danilo-leal merged commit 23bbf10 into mui:next Apr 30, 2024

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024

[website] Add content about the Sync plugin in the Material UI page (#…

2d20614

…40515) Co-authored-by: David Cnoops <davidcnoops@outlook.com> Co-authored-by: zanivan <victorzanivan@gmail.com>

github-actions bot mentioned this pull request Apr 30, 2024

[website] Add content about the Sync plugin in the Material UI page (@danilo-leal) #42074

Merged

danilo-leal deleted the add-connect-content-website branch April 30, 2024 19:48

zannager unassigned danilo-leal Mar 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[website] Add content about the Sync plugin in the Material UI page#40515

[website] Add content about the Sync plugin in the Material UI page#40515
danilo-leal merged 85 commits intomui:nextfrom
danilo-leal:add-connect-content-website

danilo-leal commented Jan 10, 2024 •

edited

Loading

Uh oh!

mui-bot commented Jan 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

zanivan left a comment

Uh oh!

danilo-leal commented Apr 30, 2024

Uh oh!

zanivan left a comment

Uh oh!

zanivan left a comment

Uh oh!

zanivan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

danilo-leal commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

Uh oh!

Uh oh!

zanivan left a comment

Choose a reason for hiding this comment

Uh oh!

danilo-leal commented Apr 30, 2024

Uh oh!

zanivan left a comment

Choose a reason for hiding this comment

Uh oh!

zanivan left a comment

Choose a reason for hiding this comment

Uh oh!

zanivan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

danilo-leal commented Jan 10, 2024 •

edited

Loading

mui-bot commented Jan 10, 2024 •

edited

Loading