Skip to content

[internal] Rely on immutable ref when possible #40831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 1 commit into from
Jan 29, 2024
Merged

[internal] Rely on immutable ref when possible #40831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mui-base/src/unstable_useModal/useModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function useModal(parameters: UseModalParameters): UseModalReturnValue {

// @ts-ignore internal logic
const modal = React.useRef<{ modalRef: HTMLDivElement; mount: HTMLElement }>({});
const mountNodeRef = React.useRef<null | HTMLElement>(null);
const mountNodeRef = React.useRef<HTMLElement | null>(null);
const modalRef = React.useRef<HTMLDivElement>(null);
const handleRef = useForkRef(modalRef, rootRef);
const [exited, setExited] = React.useState(!open);
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-material-next/src/Menu/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const MenuInner = React.forwardRef(function Menu(inProps, ref) {
const theme = useTheme();
const isRtl = theme.direction === 'rtl';

const listRef = React.useRef<HTMLElement | null>(null);
const listRef = React.useRef<HTMLElement>(null);

// TODO v6: Handle the rest of the props from the MenuListProps prop
const {
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-material-next/src/MenuItem/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ const MenuItem = React.forwardRef(function MenuItem<RootComponentType extends Re
[context.dense, dense, disableGutters],
);

const menuItemRef = React.useRef<HTMLElement | null>(null);
const menuItemRef = React.useRef<HTMLElement>(null);
const handleRef = useForkRef(menuItemRef, ref);

const { getRootProps, disabled, focusVisible, highlighted } = useMenuItem({
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-material-next/src/Option/Option.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ const Option = React.forwardRef(function Option<RootComponentType extends React.
[context.dense, dense, disableGutters],
);

const optionRef = React.useRef<HTMLElement | null>(null);
const optionRef = React.useRef<HTMLElement>(null);
const handleRef = useForkRef(optionRef, ref);

const { getRootProps, disabled, focusVisible, highlighted } = useMenuItem({
Expand Down