[docs-infra] Fix analytics about inline ads#41474
Merged
alexfauquette merged 3 commits intomui:masterfrom Apr 5, 2024
Merged
Conversation
alexfauquette
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-41474--material-ui.netlify.app/ Bundle size report |
alexfauquette
changed the title
danilo-leal
changed the title
siriwatknp
reviewed
Mar 14, 2024
Comment on lines
+28
to
+30
| if (Math.random() < 0.9 || !ad.label) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Can you explain more what's this for?
Member
Author
There was a problem hiding this comment.
Not sure about which aspect is unclear.
The early return is just a way to send only 10% of the ads display event to Goggle Analitics. A similar approach is used for top page ads
Member
Author
There was a problem hiding this comment.
I added a commit to make sure this ratio is consistent between all ads
siriwatknp
approved these changes
Apr 5, 2024
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
Thanks for the explanation!
alexfauquette
added a commit
to alexfauquette/material-ui
that referenced
this pull request
Apr 9, 2024
alexfauquette
added a commit
that referenced
this pull request
Apr 9, 2024
This was referenced May 22, 2024
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the data collection about the inline ads. Needed to collect statistics on to move on #39285
Current statistics can be seen here:
https://analytics.google.com/analytics/web/#/analysis/p353089763/edit/9w1vckV7T1umgP5PSvL3vw
The
displayandclickaction have both been tested with the Google tag assistant. They are correctly recognized 👍