Skip to content

[material-ui][Card] Convert to support CSS extraction#41580

Merged
siriwatknp merged 1 commit intomui:nextfrom
andrejsshell:mui-zero/card
Mar 21, 2024
Merged

[material-ui][Card] Convert to support CSS extraction#41580
siriwatknp merged 1 commit intomui:nextfrom
andrejsshell:mui-zero/card

Conversation

@andrejsshell
Copy link
Contributor

Hey @siriwatknp, I see the assets have not been moved to the docs, should we update the script to do that as well?

Screen.Recording.2024-03-20.at.20.17.56.mov

@mui-bot
Copy link

mui-bot commented Mar 20, 2024

Netlify deploy preview

https://deploy-preview-41580--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 606a087

@danilo-leal danilo-leal added scope: card Changes related to the card. package: material-ui labels Mar 20, 2024
@danilo-leal danilo-leal requested a review from siriwatknp March 20, 2024 20:01
@mnajdova
Copy link
Member

Hey @siriwatknp, I see the assets have not been moved to the docs, should we update the script to do that as well?

I ignored this so far, it's not worth I think. We are anyway adding these example just to validate if it works, we are not going to actually use them as a docs.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

paddingBottom: 24,
},
};
})({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, no need for a callback 👍

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: card Changes related to the card.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants