Skip to content

[material-ui][FilledInput] Convert to support CSS extraction#41663

Closed
mj12albert wants to merge 7 commits intomui:nextfrom
mj12albert:feat/filled-input-css-extraction
Closed

[material-ui][FilledInput] Convert to support CSS extraction#41663
mj12albert wants to merge 7 commits intomui:nextfrom
mj12albert:feat/filled-input-css-extraction

Conversation

@mj12albert
Copy link
Member

@mui-bot
Copy link

mui-bot commented Mar 26, 2024

Netlify deploy preview

https://deploy-preview-41663--material-ui.netlify.app/

packages/material-ui/material-ui.production.min.js: parsed: +0.15% , gzip: +0.06%
TextField: parsed: +0.46% , gzip: +0.36%
FilledInput: parsed: +0.89% , gzip: +0.61%
@material-ui/core: parsed: +0.12% , gzip: +0.07%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2661a30

@mj12albert
Copy link
Member Author

@siriwatknp At the "Render demos" step, I found that there is no docs/pages/material-ui/react-filled-input, only react-text-field

Would all the components that compose TextField need to be converted first to progress this? 🤔

@siriwatknp
Copy link
Member

@siriwatknp At the "Render demos" step, I found that there is no docs/pages/material-ui/react-filled-input, only react-text-field

Would all the components that compose TextField need to be converted first to progress this? 🤔

No need, you can use the react-text-field and check if FilledInput styles has been converted to Pigment, that all. The rest of TextFields will be emotion which should work along side with Pigment

},
},
],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for starting this. I pushed some fixes, will merge once the CIs are green.

@siriwatknp siriwatknp marked this pull request as ready for review April 25, 2024 09:48
@siriwatknp siriwatknp added scope: text field Changes related to the text field. component: input and removed scope: text field Changes related to the text field. labels Apr 25, 2024
@siriwatknp siriwatknp enabled auto-merge (squash) April 25, 2024 09:49
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 17, 2024
@siriwatknp
Copy link
Member

This work has been done in another PR.

@siriwatknp siriwatknp closed this Jul 31, 2024
auto-merge was automatically disabled July 31, 2024 03:12

Pull request was closed

@oliviertassinari oliviertassinari added the scope: text field Changes related to the text field. label Nov 12, 2024
@mj12albert mj12albert deleted the feat/filled-input-css-extraction branch November 25, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: text field Changes related to the text field.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants