[material-ui][AlertTitle] Enable extending Typography props#42269
Merged
ZeeshanTamboli merged 5 commits intomui:nextfrom May 22, 2024
Merged
[material-ui][AlertTitle] Enable extending Typography props#42269ZeeshanTamboli merged 5 commits intomui:nextfrom
ZeeshanTamboli merged 5 commits intomui:nextfrom
Conversation
Netlify deploy previewhttps://deploy-preview-42269--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
approved these changes
May 22, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@lucasgmelo Thanks for the pull request. I made the expected changes and also added a TypeScript test.
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlertTitle is now extending the properties of the Typography component according to the documentation.
I used the Pick property from TypeScript because some properties existed in both components and had different types, so I made sure to add the ones that didn't exist in AlertTitle.
e.g. color
Fixes #42015