[joy-ui][Autocomplete] Fix spread key error in test#42775
Merged
aarongarciah merged 1 commit intomui:nextfrom Jun 27, 2024
Merged
[joy-ui][Autocomplete] Fix spread key error in test#42775aarongarciah merged 1 commit intomui:nextfrom
aarongarciah merged 1 commit intomui:nextfrom
Conversation
aarongarciah
added
test
package: joy-ui
15 tasks
Netlify deploy previewhttps://deploy-preview-42775--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Jun 27, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Is the warning only triggered once? And that's why these have been showing up one by one? It would be great if we could have one PR for all of them 😅
Member
Author
|
@DiegoAndai this should be the last spread key warning in our tests. I double checked. Demos is another story (as we saw in the Autocomplete demos) because this is a runtime error that is triggered only when the piece of JSX runs. In the case of Autocomplete, most warnings were triggered when opening it. |
DiegoAndai
approved these changes
Jun 27, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a React warning caused by
keybeing spread. This only happens starting with React 18.3