Skip to content

[internal] Remove react-test-renderer#42784

Merged
aarongarciah merged 4 commits intomui:nextfrom
aarongarciah:remove-react-test-renderer
Jun 30, 2024
Merged

[internal] Remove react-test-renderer#42784
aarongarciah merged 4 commits intomui:nextfrom
aarongarciah:remove-react-test-renderer

Conversation

@aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 28, 2024

This PR removes the react-test-renderer dependency, the last test using it in describeConformance, and other related code.

Context:

  • react-test-renderer was deprecated in React 18.3
  • React 19 will start throwing a warning when using react-test-renderer

@aarongarciah aarongarciah added test internal Behind-the-scenes enhancement. Formerly called “core”. needs cherry-pick The PR should be cherry-picked to master after merge. integration: react About improving React support. labels Jun 28, 2024
@aarongarciah aarongarciah mentioned this pull request Jun 28, 2024
15 tasks
@aarongarciah aarongarciah requested a review from a team June 28, 2024 15:51
@mui-bot
Copy link

mui-bot commented Jun 28, 2024

Netlify deploy preview

https://deploy-preview-42784--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 593fb75

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏 💯 🚀

@aarongarciah aarongarciah merged commit fea558d into mui:next Jun 30, 2024
@aarongarciah aarongarciah deleted the remove-react-test-renderer branch June 30, 2024 14:20
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
13 tasks
@aarongarciah aarongarciah added the dependencies Update of dependencies. label Jul 5, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@oliviertassinari oliviertassinari changed the title [core] Remove react-test-renderer [internal] Remove react-test-renderer Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update of dependencies. integration: react About improving React support. internal Behind-the-scenes enhancement. Formerly called “core”. needs cherry-pick The PR should be cherry-picked to master after merge. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants