[material-ui][joy-ui] Remove warning from getInitColorSchemeScript#42838
[material-ui][joy-ui] Remove warning from getInitColorSchemeScript#42838siriwatknp merged 7 commits intomui:masterfrom
getInitColorSchemeScript#42838Conversation
Netlify deploy previewhttps://deploy-preview-42838--material-ui.netlify.app/ @material-ui/core: parsed: -0.05% 😍, gzip: -0.08% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
| useColorScheme, | ||
| getInitColorSchemeScript: deprecatedGetInitColorSchemeScript, | ||
| } = createCssVarsProvider<SupportedColorScheme, typeof THEME_ID>({ | ||
| const { CssVarsProvider, useColorScheme, getInitColorSchemeScript } = createCssVarsProvider< |
There was a problem hiding this comment.
We should add the @deprecated tag to getInitColorSchemeScript to hint at it in IDEs
| * + <InitColorSchemeScript />; | ||
| * ``` | ||
| */ | ||
| export const getInitColorSchemeScript = getInitColorSchemeScriptSystem; |
There was a problem hiding this comment.
I've added redeclaration to improve the jsdoc, because it doesn't work well when added to reexport:
| Before | After |
|---|---|
 |
 |
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
What's with the ci.yml change?
This error https://github.com/mui/material-ui/actions/runs/9806956012/job/27079721815. Not related to this PR, the fix is to upgrade the version but I don't know the root cause. |
5 participants
From #42829 (comment)
Updated the docs to fallback to
getInitColorSchemeScriptin v5 (MUI X needs this).