[utils][test] Remove unnecessary ref param#43282
Merged
aarongarciah merged 1 commit intonextfrom Aug 13, 2024
Merged
Conversation
aarongarciah
commented
Aug 13, 2024
Comment on lines
-44
to
+50
| const AnonymousMemoComponent = React.memo((props, ref) => <div {...props} ref={ref} />); | ||
| const AnonymousMemoComponent = React.memo((props) => <div {...props} />); | ||
|
|
||
| const MemoComponent = React.memo(function Div(props, ref) { | ||
| return <div {...props} ref={ref} />; | ||
| const MemoComponent = React.memo(function Div(props) { | ||
| return <div {...props} />; | ||
| }); | ||
|
|
||
| const NamedMemoComponent = React.memo((props, ref) => <div {...props} ref={ref} />); | ||
| const NamedMemoComponent = React.memo((props) => <div {...props} />); |
Member
Author
There was a problem hiding this comment.
React 19 types complain about React.memo receiving a ref param.
Also, the ref param does nothing because the component is not using React.forwardRef, hence ref is unnecessary. It's probably there because of copy pasting.
DiegoAndai
approved these changes
Aug 13, 2024
Member
|
Nice small scoped PR 👍 |
37 tasks
DiegoAndai
pushed a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #42381
Extracted from https://github.com/mui/material-ui/pull/42824/files#r1715334482