[infra] Add closing message workflow#43450
Conversation
michelengelen
added
type: enhancement
michelengelen
requested review from
JCQuintas,
mj12albert,
mnajdova and
oliviertassinari
Netlify deploy previewhttps://deploy-preview-43450--material-ui.netlify.app/ Bundle size report |
|
Is this comment left only when the issue is resolved/fixed? |
It's always left ... you don't seem to use the stale issue workflow, right? |
|
we could probably adjust this to not post the comment, when the issue is closed as |
|
I meant we likely shouldn't leave it if for example if it has the labels: "status: waiting for author", "duplicated", "support: StackOverflow" etc. We are leaving different messages in these scenarios. |
|
We need to check how are the issues closed in these scenarios (the manual one should be already covered by your last commit). |
|
OK, I just looked over the workflows in this repo and it seems you close for a few reasons:
I could not find any other scenarios, so considering these and the manual action is also covered we should be good with these changes, right? 😄 |
| If you have a question on Stack Overflow, you are welcome to link to it here, it might help others. | ||
| If your issue is subsequently confirmed as a bug, and the report follows the issue template, it can be reopened. | ||
| close-issue: true | ||
| issue-close-reason: 'not planned' |
There was a problem hiding this comment.
This is what needed to be checked, nice!
There was a problem hiding this comment.
We should roll this change to all the other repositories, right? I imagine it's about https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/.
I'm also not sure how to feel about not asking for support feedback on an issue we closed as not planned. I guess it makes sense, what we would get is mostly people not happy 😄. Kind of https://www.oesterlund.dev/blog/learnings-from-one-year-of-building-an-open-source-project#learning-2-dont-even-try-to-please-everyone, built a system that makes us default to not try to please everyone.
There was a problem hiding this comment.
Yes, the plan is to roll this out to all repos that have at least some user visibility.
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Cool, let's try this! Thanks 🙏
|
I created #43451 to fix the CI issue, @siriwatknp is handling the other changes needed for the stable release |
|
@michelengelen you can update to latest master and merge, the CI blocker was just merged. |
…mation/add-closing-message
|
@michelengelen I started receiving these email notifications, is there a way to avoid them? 
|
You should just unsubscribe from the workflow runs... you can do that in the GitHub settings. |
|
@michelengelen yeah, I can unsubscribe from workflow runs notifications, but I like to be notified about failed workflows. I guess the question is: why is this particular workflow failing? These notifications can be very noisy as I think I'm receiving one for every commit pushed to any given PR. |
With #43464 this should not fail anymore! 👍🏼 I thought you can unsubscribe from specific workflows as well, but that might not be the case! |
|
Awesome, thank you! |
5 participants
Adds the reusable workflow of adding a message on closed issues (like in thew x repo)
This is using a reusable workflow to decrease friction on changes.