[ThemeProvider] Support setting default mode#43951
Merged
siriwatknp merged 4 commits intomui:masterfrom Oct 1, 2024
Merged
Conversation
siriwatknp
added
scope: system
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
Janpot
reviewed
Oct 1, 2024
Janpot
approved these changes
Oct 1, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Small suggestion to satisfy vale, otherwise looks good.
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
aarongarciah
approved these changes
Oct 1, 2024
| */ | ||
| documentNode?: Document | null; | ||
| /** | ||
| * The default mode when the storage is empty, |
Member
There was a problem hiding this comment.
What does "storage" mean? Could we specify a bit more?
Member
Author
There was a problem hiding this comment.
May be local storage is more direct?
siriwatknp
commented
Oct 1, 2024
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
|
this one was life saver: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43622
Changes
The default mode can be controlled by a prop (see #43622 for use cases):