Conversation
Netlify deploy previewhttps://deploy-preview-47948--material-ui.netlify.app/ Bundle size report
|
bbaed45 to
842cbc8
Compare
842cbc8 to
f794676
Compare
f794676 to
f42e38d
Compare
f98e035 to
05865a4
Compare
05865a4 to
f17ca27
Compare
f17ca27 to
56a4426
Compare
|
Not sure if the deployment failure is something that I introduced. Could it be an issue on something I added? |
|
@filipomar Is it important for your use-case that the value in the change handlers are also readonly arrays? Asking because it's a breaking change, but wouldn't be breaking if we only changed the input to also accept readonly array |
Actually it is not. With all of that being said, if I am able to make the input readonly but the callbacks type not, (hopefully) without completely refactoring everything, would that be ok? Or do you forsee other issues? |
This PR updates the types of the AutoComplete component and hook so readonly arrays values can be passed.
I went through the component and attempted to narrow the types of any other function consuming the value.