[ButtonBase] Key handlers should not run on a disabled non-native button#48003
Merged
mj12albert merged 3 commits intomui:masterfrom Mar 17, 2026
Merged
Conversation
mj12albert
added
breaking change
Netlify deploy previewBundle size report
|
mj12albert
changed the title
mj12albert
changed the title
silviuaavram
approved these changes
Mar 17, 2026
Member
silviuaavram
left a comment
silviuaavram
left a comment
There was a problem hiding this comment.
Looks good! Since it's a breaking change, maybe we need to mention it in the upgrade guide? What do you think?
siriwatknp
reviewed
Mar 17, 2026
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
If it's breaking change, it should be added to the upgrade guide
mnajdova
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor breaking change: Disabled non-native
ButtonBase(e.g. aspan) can still be programmatically focused when disabled and incorrectly fire key events.Doesn't not affect any Material UI components that internally use ButtonBase, the change would only affect users directly using ButtonBase to render a non-native button, and somehow relying on key events firing on it when disabled