Skip to content

[all components] Fix slotProps.transition types#48153

Merged
mj12albert merged 3 commits intomui:masterfrom
mj12albert:fix/transition-slotprops-types
Mar 31, 2026
Merged

[all components] Fix slotProps.transition types#48153
mj12albert merged 3 commits intomui:masterfrom
mj12albert:fix/transition-slotprops-types

Conversation

@mj12albert
Copy link
Copy Markdown
Member

Fixes #48145

@mj12albert mj12albert added typescript scope: transitions Changes related to the transitions. labels Mar 30, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 30, 2026

Netlify deploy preview

https://deploy-preview-48153--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against c28ac15

@mj12albert mj12albert marked this pull request as ready for review March 30, 2026 16:14
Copy link
Copy Markdown
Member

@silviuaavram silviuaavram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some test related comments. We should also add cherry pick tags

*/
transition: SlotComponentProps<
React.ElementType,
React.ElementType<TransitionProps>,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add Backdrop.test.tsx and test the type

* By default, the available props are based on the [Zoom](https://mui.com/material-ui/api/zoom/#props) component.
*/
transition: SlotComponentProps<React.ElementType, TransitionProps, SpeedDialOwnerState>;
transition: SlotComponentProps<
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for speedial

@mj12albert mj12albert added v7.x needs cherry-pick The PR should be cherry-picked to master after merge. labels Mar 31, 2026
@mj12albert mj12albert enabled auto-merge (squash) March 31, 2026 12:42
@mj12albert mj12albert merged commit 8182ae9 into mui:master Mar 31, 2026
19 checks passed
@github-actions
Copy link
Copy Markdown

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. scope: transitions Changes related to the transitions. typescript v7.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[accordion] slotProps.transition is not type-safe

3 participants