[data grid] Use readonly array result for getTreeDataPath#11743
Merged
romgrk merged 2 commits intomui:masterfrom Aug 22, 2024
Merged
[data grid] Use readonly array result for getTreeDataPath#11743romgrk merged 2 commits intomui:masterfrom
romgrk merged 2 commits intomui:masterfrom
Conversation
|
Deploy preview: https://deploy-preview-11743--material-ui-x.netlify.app/ |
pcorpet
force-pushed
the
readonly-tree-data-path
branch
from
982d960 to
9308a68
Compare
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
pcorpet
force-pushed
the
readonly-tree-data-path
branch
from
9308a68 to
857d7f2
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
changed the title
We do not try to modify the array after receiving it, so let's accept an immutable array. This is still compatible with existing usage of getTreeDataPath.
pcorpet
force-pushed
the
readonly-tree-data-path
branch
from
857d7f2 to
7cc32b1
Compare
romgrk
approved these changes
Aug 12, 2024
This was referenced Sep 19, 2024
This was referenced Sep 22, 2024
This was referenced Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not try to modify the array after receiving it, so let's accept an immutable array. This is still compatible with existing usage of getTreeDataPath.