[support-infra] Add release announcement to GitHub workflows#11867
[support-infra] Add release announcement to GitHub workflows#11867michelengelen merged 11 commits intomui:nextfrom
Conversation
…or string into the changelog script
michelengelen
added
internal
michelengelen
requested review from
DanailH,
joserodolfofreitas and
oliviertassinari
|
Deploy preview: https://deploy-preview-11867--material-ui-x.netlify.app/ |
joserodolfofreitas
left a comment
joserodolfofreitas
left a comment
There was a problem hiding this comment.
This is great, @michelengelen! Thank you for pushing forward on this front!
| name: Send message to discord | ||
| steps: | ||
| - name: parse and send message | ||
| uses: michelengelen/discord-message-action@02af30a15955ecf718049bc33b0efabf6f626e0b |
There was a problem hiding this comment.
By the way, maybe we should review the action itself? Since it's the most essential part of the code.
There was a problem hiding this comment.
Oh yes ... please go ahead. It's my private one, so nothing to hide there! :D
There was a problem hiding this comment.
This is the link to it for reference: https://github.com/michelengelen/discord-message-action
There was a problem hiding this comment.
I checked it - seems good. I think we can move forward and add this to the release workflow
oliviertassinari
changed the title
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
Nice 👍
I guess we don't use https://github.com/marketplace/actions/github-releases-to-discord to have the highlight extract.
No, we don't, since every action available was either not working or did not have the feature set we wanted. |
michelengelen
requested review from
danilo-leal,
joserodolfofreitas and
oliviertassinari
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Sweet! Can this be extended to the Core side of the world, too? If yes, a follow up question would be if it is possible to cherry pick which announcements go to Discord?
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
added
scope: code-infra
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
|
Can we move on with this PR or are there any change requests from either of you? |
michelengelen
changed the title
michelengelen
added
the
needs cherry-pick
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…) (mui#12843) Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
6 participants
This action will send a message to the #announcements channel on our discord server when there is a new release (events:
release:publishedandrelease:prereleased).For this to work we need to add a separator line into the changelog. This will be a comment string sitting just before the detailed changes.
This string needs to stay in order for the script to know where the highlights end.
The reason why we are doing this is that Discord does not allow messages to be above 2000 characters.
The message posted will look like this (tested with the v7-beta-0 Changelog):
