[TreeView] Add label editing feature#13388
Merged
noraleonte merged 110 commits intomui:masterfrom Aug 13, 2024
Merged
Conversation
noraleonte
added
type: new feature
|
Deploy preview: https://deploy-preview-13388--material-ui-x.netlify.app/ Updated pages: |
github-actions
bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewLabel/useTreeViewLabel.itemPlugin.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
PR: out-of-date
noraleonte
commented
Jun 17, 2024
packages/x-tree-view/src/hooks/useTreeItem2Utils/useTreeItem2Utils.tsx
Outdated
Show resolved
Hide resolved
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
For me we are almost good to go
I think we need to make the feature unstable like the drag & drop one, I would follow the same pattern and just add an experimentalFeature={{ labelEditing }} flag.
docs/data/tree-view/rich-tree-view/editing/CustomLabelInput.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
LukasTy
reviewed
Aug 6, 2024
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Looks great, awesome work! 🎉💯
Leaving a couple final comments regarding demos. 👍
packages/x-tree-view/src/internals/plugins/useTreeViewLabel/useTreeViewLabel.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
approved these changes
Aug 13, 2024
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
Thanks for the terrific work on this feature! 👏
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
https://deploy-preview-13388--material-ui-x.netlify.app/x/react-tree-view/rich-tree-view/editing/
To do: