[charts] Rename CartesianContextProvider to CartesianProvider#14102
[charts] Rename CartesianContextProvider to CartesianProvider#14102JCQuintas merged 1 commit intomui:masterfrom
CartesianContextProvider to CartesianProvider#14102Conversation
JCQuintas
added
type: enhancement
|
Deploy preview: https://deploy-preview-14102--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14102 will not alter performanceComparing Summary
|
|
@alexfauquette this should be ready to review and decrease the amount of lines on #14121 😆 |
| <ZoomProvider {...zoomProviderProps}> | ||
| <SeriesProvider {...seriesProviderProps}> | ||
| <CartesianProviderPro {...cartesianProviderProps}> |
There was a problem hiding this comment.
I assume the reordeing has a reason in the PR for zoom filterMode?
There was a problem hiding this comment.
yep, though I think in the end I didn't use it
There was a problem hiding this comment.
Maybe this can be reverted then to avoid introducing modification. But that recommendation seems more like psychologic safety than true engineering 😇
| <ZoomProvider {...zoomProviderProps}> | ||
| <SeriesProvider {...seriesProviderProps}> | ||
| <CartesianProviderPro {...cartesianProviderProps}> |
There was a problem hiding this comment.
Maybe this can be reverted then to avoid introducing modification. But that recommendation seems more like psychologic safety than true engineering 😇
3 participants
One more renaming 🙃