[code-infra] Fix failing Netlify build#14104
Closed
cherniavskii wants to merge 1 commit intomui:masterfrom
Closed
Conversation
|
Deploy preview: https://deploy-preview-14104--material-ui-x.netlify.app/ |
Member
|
Did you have to do any change on |
cherniavskii
commented
Aug 5, 2024
Member
Author
There was a problem hiding this comment.
@JCQuintas It's pure copy/paste from the latest next branch of the monorepo, not a single character changed:
https://github.com/mui/material-ui/blob/f9de2dd508b59623a99949f8891b96cf0016581c/docs/pages/_document.js
Member
|
It looks like our Netlify config might not be ideal based on their doc and the following points from.
WDYT about trying this approach? 🤔 |
This was referenced Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After experimenting with different things in #13623 (you can see my commits if you're curious about what I tried), I managed to have the Netlify build working again.
I don't know what the origin of the issue is and why it's not reproducible locally after clearing the cache.
Testing:
56f5131(#13623) and it fixed the failing build.masterinto one of the PRs that has the build failingOther attempts
@mui/joyinstalled on Netlify. Commit Deploymentdocs/.next) Commit Deploymentmaster. Commit Deployment