[data grid] Fix CSV export for null and undefined values#14166
Merged
arminmeh merged 6 commits intomui:masterfrom Aug 14, 2024
Merged
[data grid] Fix CSV export for null and undefined values#14166arminmeh merged 6 commits intomui:masterfrom
null and undefined values#14166arminmeh merged 6 commits intomui:masterfrom
Conversation
Contributor
Author
|
not sure if this check should stay here or not, it probably not |
1 task
null and undefined valuesnull and undefined values
Contributor
I have removed this, thanks for pointing it out |
Contributor
|
I have added a test to the PR, to prevent future regressions. |
arminmeh
approved these changes
Aug 12, 2024
|
Deploy preview: https://deploy-preview-14166--material-ui-x.netlify.app/ |
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14082
this issue comes from the changes done in #13560 , the motive of that PR is to convert any non-string value into a string using template literals but it also converts
nullandundefinedvalues into strings which then exported to CSV as a string.I have added a check for these values.