[internal] Use event.key for Tab and Escape keys#14170
Merged
romgrk merged 3 commits intomui:masterfrom Aug 16, 2024
Merged
Conversation
michelengelen
approved these changes
Aug 12, 2024
Member
michelengelen
left a comment
michelengelen
left a comment
There was a problem hiding this comment.
LGTM ... thanks for your contribution.
romgrk
reviewed
Aug 13, 2024
packages/x-data-grid/src/components/toolbar/GridToolbarDensitySelector.tsx
Outdated
Show resolved
Hide resolved
romgrk
approved these changes
Aug 13, 2024
|
Deploy preview: https://deploy-preview-14170--material-ui-x.netlify.app/ |
oliviertassinari
added
the
internal
oliviertassinari
changed the title
event.key for Tab and Escape keysevent.key for Tab and Escape keys
oliviertassinari
changed the title
event.key for Tab and Escape keysevent.key for Tab and Escape keys
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
oliviertassinari
changed the title
event.key for Tab and Escape keysevent.key for Tab and Escape keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little cleanup PR
we are already using
event.keyeverywhere for different keys so why not forTabandEscapekeys ?