Skip to content

[DataGrid] Remove needless check in useGridStateInitialization#14181

Merged
romgrk merged 5 commits intomui:masterfrom
k-rajat19:remove-check
Aug 15, 2024
Merged

[DataGrid] Remove needless check in useGridStateInitialization#14181
romgrk merged 5 commits intomui:masterfrom
k-rajat19:remove-check

Conversation

@k-rajat19
Copy link
Contributor

publishEvent is always available during grid state initialization (because we are adding it in API synchronously before state initialization) so there is no need to check that.

@zannager zannager added the scope: data grid Changes related to the data grid. label Aug 13, 2024
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@romgrk romgrk enabled auto-merge (squash) August 13, 2024 18:37
@mui-bot
Copy link

mui-bot commented Aug 13, 2024

Deploy preview: https://deploy-preview-14181--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7344cc5

@arminmeh
Copy link
Contributor

@k-rajat19 can you run pnpm prettier and commit the changes?

auto-merge was automatically disabled August 14, 2024 09:08

Head branch was pushed to by a user without write access

@k-rajat19
Copy link
Contributor Author

@k-rajat19 can you run pnpm prettier and commit the changes?

Done👍

@romgrk romgrk enabled auto-merge (squash) August 15, 2024 00:26
@romgrk romgrk merged commit 403d6ff into mui:master Aug 15, 2024
@k-rajat19 k-rajat19 deleted the remove-check branch August 15, 2024 06:18
@oliviertassinari oliviertassinari changed the title [DataGrid] remove needless check in useGridStateInitialization [DataGrid] Remove needless check in useGridStateInitialization Oct 1, 2024
@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. scope: data grid Changes related to the data grid.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants