Use isPointInside function for both graphs and axis

[JCQuintas]

• This normalises the code to use the same logic in both instances.
• It also fixes an issue where the axis would show before the datapoint, even though the were displayed in the same line.

import * as React from 'react';
import { ScatterChartPro, ZoomData } from '@mui/x-charts-pro';

export default function AreaBaseline() {
  const [scatterZoom, setScatterZoom] = React.useState<ZoomData[]>([
    { axisId: 'b11', start: 11, end: 49 },
  ]);

  return (
      <ScatterChartPro
        xAxis={[{ id: 'b11', zoom: true }]}
        series={[
          {
            data: [
              { id: 0, x: 1, y: 100 },
              { id: 2, x: 5, y: 200 },
              { id: 3, x: 10, y: 300 },
              { id: 4, x: 15, y: 400 },
              { id: 5, x: 20, y: 500 },
            ],
          },
        ]}
        zoom={scatterZoom}
        onZoomChange={setScatterZoom}
        width={500}
        height={300}
        leftAxis={{}}
        rightAxis={{}}
        topAxis={{}}
        bottomAxis={{}}
      />
      <ScatterChartPro
        yAxis={[{ id: 'b11', zoom: true }]}
        series={[
          {
            data: [
              { id: 0, x: 1, y: 100 },
              { id: 2, x: 5, y: 200 },
              { id: 3, x: 10, y: 300 },
              { id: 4, x: 15, y: 400 },
              { id: 5, x: 20, y: 500 },
            ],
          },
        ]}
        leftAxis={{}}
        rightAxis={{}}
        topAxis={{}}
        bottomAxis={{}}
        zoom={scatterZoom}
        onZoomChange={setScatterZoom}
        width={500}
        height={300}
      />
  );
}

[mui-bot]

Deploy preview: https://deploy-preview-14222--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 37bc0d7

[codspeed-hq]

CodSpeed Performance Report

Merging #14222 will not alter performance

_{Comparing JCQuintas:fix-is-point-inside-offsets (37bc0d7) with master (c911ad5)}

Summary

✅ 3 untouched benchmarks

[romgrk]

I'm not sure if it matters much, but the shape { x?: number, y:? number } is un-monomorphizing the isPointInside function. If it's a hot function, could be worth to pass a placeholder value like { x: offset, y: -1 }.

[alexfauquette]

LGTM. Feel free to implement Romain proposal. It's true that this function might be called a lot