[DataGrid] Introduce selectors with arguments#14236
Merged
MBilalShafi merged 6 commits intomui:masterfrom Aug 22, 2024
Merged
Conversation
MBilalShafi
added
internal
|
Deploy preview: https://deploy-preview-14236--material-ui-x.netlify.app/ |
MBilalShafi
commented
Aug 16, 2024
11 tasks
romgrk
reviewed
Aug 22, 2024
romgrk
reviewed
Aug 22, 2024
romgrk
approved these changes
Aug 22, 2024
Contributor
romgrk
left a comment
romgrk
left a comment
There was a problem hiding this comment.
As long as useGridSelectorV8 isn't public we can still refactor it if we find an issue with it later, so I'm good with merging this PR as it is.
arminmeh
approved these changes
Aug 22, 2024
MBilalShafi
changed the title
12 tasks
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #13757
Related discussion: https://github.com/mui/mui-x/pull/13757/files#r1686750062
Changelog
useGridSelector,createSelector, andcreateSelectorMemoizednamed asuseGridSelectorV8,createSelectorV8, andcreateSelectorMemoizedV8. Selectors created withcreateSelectorV8orcreateSelectorMemoizedV8must be used withuseGridSelectorV8for them to work properly. These new variants will replace the existing props in v8.Todos