[docs] Fix missing leading slashes in URLs#14249
Conversation
oliviertassinari
added
type: bug
| onKeyDown={(e: React.KeyboardEvent) => { | ||
| onKeyDown={(event: React.KeyboardEvent) => { |
There was a problem hiding this comment.
Code policy to avoid shorthands
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDayjs}> | ||
| <DemoWrapper link="/x/react-date-pickers/validation"> | ||
| <DemoWrapper link="/x/react-date-pickers/validation/"> |
There was a problem hiding this comment.
This is the same case as the pricing page, but it's not as visible, Netlify has a bug: https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/11.
| <Stack direction="row" spacing={2} sx={{ mb: description ? 2 : 0, width: '100%' }}> | ||
| <Stack | ||
| direction="row" | ||
| spacing={2} | ||
| sx={{ mb: description ? 2 : 0, width: '100%', alignItems: 'center' }} | ||
| > |
There was a problem hiding this comment.
oliviertassinari
changed the title
|
Deploy preview: https://deploy-preview-14249--material-ui-x.netlify.app/ |
oliviertassinari
added
the
type: regression
LukasTy
changed the title
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
LGTM. 💯
Thank you for taking care of it. 👍
| selectedKey.location === location, | ||
| })} | ||
| onMouseDown={(e) => { | ||
| onMouseDown={(event) => { |
There was a problem hiding this comment.
Nitpick: The code for these demos is not visible anywhere in the docs, so, it's not a visible problem. 👍
There was a problem hiding this comment.
I'm not sure. I could fix https://github.com/mui/material-ui/pull/43361/files because I could get a hit for my search of "event.key.toLowerCase() === 'c'" in the MUI's codebase. I didn't search for "e.key.toLowerCase() === 'c'"
| <Stack direction="row" spacing={2} sx={{ mb: description ? 2 : 0, width: '100%' }}> | ||
| <Stack | ||
| direction="row" | ||
| spacing={2} | ||
| sx={{ mb: description ? 2 : 0, width: '100%', alignItems: 'center' }} | ||
| > |
noraleonte
left a comment
noraleonte
left a comment
There was a problem hiding this comment.
Thanks for fixing these 🎉
5 participants
I first saw this in https://app.ahrefs.com/site-audit/3992793/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2CredirectChainUrls%2CisRedirectLoop%2CincomingAllLinks%2CincomingRedirect%2Corigin¤t=16-08-2024T023256&filterId=808b08e88c934ee19e04fdec4ed87a5a&issueId=c64d12c1-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating
we link to "/pricing" but should be "/pricing/". Now, since this page gets versioned, e.g. https://v6.mui.com/x/react-date-pickers/ we can't use a relative URL, we have to use an absolute one, so https://mui.com/pricing/ in the end.
I opened a PR as it seemed equivalent to leaving the feedback.