[TreeView] Clean label editing code#14264
Conversation
flaviendelangle
added
the
scope: tree view
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
8e3ea4f to
4484573
Compare
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
4484573 to
cdab9e0
Compare
|
Deploy preview: https://deploy-preview-14264--material-ui-x.netlify.app/ |
| @@ -1,8 +1,12 @@ | |||
| export interface TreeItem2LabelInputProps extends React.InputHTMLAttributes<HTMLInputElement> { | |||
There was a problem hiding this comment.
We should avoid to add props we don't actually use to the typing of our slots.
That way people implementing custom slots only need to support the props we actually need and not all the props we could theoretically use on our default slot component.
| UseTreeViewLabelSignature, | ||
| } from './useTreeViewLabel.types'; | ||
|
|
||
| export const isAndroid = () => navigator.userAgent.toLowerCase().includes('android'); |
| experimentalFeatures: 'labelEditing'; | ||
| dependencies: [UseTreeViewItemsSignature]; | ||
| }>; | ||
| export interface UseTreeItem2LabelInputSlotPropsFromItemsReordering |
There was a problem hiding this comment.
Typo in the name and the props were never added to the typing of UseTreeItem2LabelInputSlotProps
| return {}; | ||
| } | ||
|
|
||
| const handleKeydown = ( |
There was a problem hiding this comment.
Move those two callbacks here, that way useTreeItem2 is totally agnostic of anything regarding this prop
We have some infos about label editing in other slots but nothing too important
flaviendelangle
changed the title
flaviendelangle
force-pushed
the
label-input-cleanup
branch
from
e883c8a to
5070e7d
Compare
noraleonte
left a comment
noraleonte
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! 🎉
packages/x-tree-view/src/TreeItem2LabelInput/TreeItem2LabelInput.types.ts
Show resolved
Hide resolved
3 participants
No description provided.