[DataGridPro] Fix double top border in header filters#14375
[DataGridPro] Fix double top border in header filters#14375MBilalShafi merged 4 commits intomui:masterfrom
Conversation
MBilalShafi
added
type: bug
|
Deploy preview: https://deploy-preview-14375--material-ui-x.netlify.app/ |
kenanyusuf
left a comment
kenanyusuf
left a comment
There was a problem hiding this comment.
Nice spot, looks good to me.
There was a problem hiding this comment.
Minor issue, if you look close enough the border doesn't extend all the way over the vertical scrollbar. If you address this, also make sure it looks fine with top pinned rows.
There was a problem hiding this comment.
With the new changes it messes the border in bottom pinned rows. I don't think we should be removing the top-border where there is one, it seems like we should be adding a bottom-border where one is needed.
There was a problem hiding this comment.
With the new changes it messes the border in bottom pinned rows. I don't think we should be removing the top-border where there is one, it seems like we should be adding a bottom-border where one is needed.
Yes, I noted it too. On it. Thanks for identifying.
There was a problem hiding this comment.
Did some updates, and it looks good to me now, tested in https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-nf5rcj?file=%2Fsrc%2Fdemo.tsx%3A75%2C1
4 participants
Spotted while working on #14373
Before Preview: https://deploy-preview-14366--material-ui-x.netlify.app/x/react-data-grid/filtering/header-filters/
After Preview: https://deploy-preview-14375--material-ui-x.netlify.app/x/react-data-grid/filtering/header-filters/
Fixes