[internal] Move warning methods to @mui/x-internals#14528
Merged
LukasTy merged 4 commits intomui:masterfrom Sep 9, 2024
Merged
[internal] Move warning methods to @mui/x-internals#14528LukasTy merged 4 commits intomui:masterfrom
@mui/x-internals#14528LukasTy merged 4 commits intomui:masterfrom
Conversation
oliviertassinari
added
the
internal
oliviertassinari
changed the title
@mui/x-internals@mui/x-internals
LukasTy
added
the
CLA: signed
LukasTy
approved these changes
Sep 9, 2024
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Thank you for your contribution! 🙏
The changes look great. 👍
They impact commercial code, but I've checked that you have already signed the CLA. 👌
I have pushed an empty commit to trigger CI.
CircleCI sometimes fails to run pipelines on contributor PRs. 🙈 🤷
|
Deploy preview: https://deploy-preview-14528--material-ui-x.netlify.app/ |
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Lukas <llukas.tyla@gmail.com>
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
oliviertassinari
changed the title
@mui/x-internals@mui/x-internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these methods should be moved to x-internals.
Related to mui/base-ui#615