[test] Remove dead act() logic#14529
Merged
cherniavskii merged 1 commit intomui:masterfrom Sep 9, 2024
Merged
Conversation
oliviertassinari
changed the title
act() logic
|
Deploy preview: https://deploy-preview-14529--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
Sep 9, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setProps()seems to call https://github.com/mui/material-ui/blob/dcc17031aa37b251678c39628b15637ec758d6b4/packages-internal/test-utils/src/createRenderer.tsx#L316 which seems to call https://github.com/testing-library/react-hooks-testing-library/blob/1e01273374af4e48a0feb1f2233bf6c76d742167/src/dom/pure.ts#L22 so this looks like dead code.This was added in #8097.
I have noticed this in #14442 while I was quickly checking the CLA signed workflow, I looked at the PR diff and this seemed odd to me.