Skip to content

[release] v7.18.0#14670

Merged
kenanyusuf merged 7 commits intomui:masterfrom
kenanyusuf:release-7.18.0
Sep 20, 2024
Merged

[release] v7.18.0#14670
kenanyusuf merged 7 commits intomui:masterfrom
kenanyusuf:release-7.18.0

Conversation

@kenanyusuf
Copy link
Member

No description provided.

@kenanyusuf kenanyusuf added the release We are shipping :D. label Sep 19, 2024
@kenanyusuf kenanyusuf marked this pull request as ready for review September 19, 2024 09:28
@kenanyusuf kenanyusuf requested a review from a team September 19, 2024 09:29
@mui-bot
Copy link

mui-bot commented Sep 19, 2024

Deploy preview: https://deploy-preview-14670--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c63debc

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost nothing in eXplore this week 😆

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-run changelog generation after #14673 is merged?
We'll have it and #11780 to include. 👍

kenanyusuf and others added 3 commits September 19, 2024 15:30
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@cherniavskii
Copy link
Member

@kenanyusuf The failing unit test is flaky, you can ignore it. I believe it will be fixed by #14583

Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@kenanyusuf kenanyusuf merged commit ae3659d into mui:master Sep 20, 2024
@kenanyusuf kenanyusuf deleted the release-7.18.0 branch September 20, 2024 08:12
@oliviertassinari oliviertassinari changed the title v7.18.0 [release] v7.18.0 Sep 22, 2024

- 💫 Support [Row spanning](https://mui.com/x/react-data-grid/row-spanning/) on the Data Grid that automatically merges the consecutive cells in a column based on the cell value

<img width="600" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a height would improve the UX.

Suggested change
<img width="600" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" />
<img width="600" height="326" src="https://github.com/user-attachments/assets/d32ec936-d238-4c92-9e1a-af6788d74cdf" alt="data grid row spanning" />

so the content doesn't move while reading the changelog after the video loads.


On the video itself, I think that correct scale + x2 pixel density + higher fps would improve the UX. See the guide in https://www.notion.so/mui-org/High-quality-media-5a1686758f4f4267989b67a1c2c270da?pvs=4#03d3a56e4f3e4890be21a6d56a005194. Here is how it feel for comparison:

before

after

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for linking the page, it definitely looks better.

arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release We are shipping :D.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants