[test] Revert to using fireEvent instead of userEvent#14927
[test] Revert to using fireEvent instead of userEvent#14927cherniavskii merged 7 commits intomui:masterfrom
fireEvent instead of userEvent#14927Conversation
|
Deploy preview: https://deploy-preview-14927--material-ui-x.netlify.app/ |
|
Why revert these changes though? |
@cherniavskii because the amount of flaky Picker test failures has been too intense lately. I have tried moving most of the Pickers tests to async in #14583 and it caused way more flaky failures. 🙈 It seems that we can not reliably mix async and sync tests while we are on mocha because it has trouble isolating test contexts. 🤷 |
|
However, for some reason, I haven't seen How has it been in everyone's branches? 🤔 |
|
I've converted the PR to a draft until we see a new flaky |
|
Here we go again... 🙈 |
|
@LukasTy Do you think we can have the |
This (7a66b0e) seemed to do the trick. |
| '@mui/material@6.x', | ||
| '@mui/system@6.x', | ||
| '@mui/icons-material@6.x', | ||
| '@mui/utils@6.x', |
There was a problem hiding this comment.
I have added the @mui/utils bump to make it more correct. 🤔
I feel like after #14867 it makes sense. 🤷
|
The PR is ready for review. |
|
Some tests are still flaky on the |
Revert changes introduced in #14142 in an effort to avoid leaking configuration and flakily failing tests.
There were no flaky
test_unitfailures on this branch. 👌