[data grid] Add Api type param to cell params model

[k-rajat19]

• I have followed (at least) the PR section of the contributing guide.

Closes #15963
Closes #12148

[mui-bot]

Deploy preview: https://deploy-preview-15968--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8f0baa6

[k-rajat19]

@michelengelen, could you review this?
Side Note: I'm not reexporting these types for pro and premium packages separately, one can pass pro and premium grid API in Api type param easily.

[michelengelen]

LGTM, but I would like a second review from @arminmeh about this.

[arminmeh]

Side Note: I'm not reexporting these types for pro and premium packages separately, one can pass pro and premium grid API in Api type param easily.

Is this expected from the users?

Looking backwards, I think that we shouldn't have done this
#14201 (related issue #14190)

This made api public API

We are not accessing api in any of our examples. People can use internal API, but that does not mean that we have to make it public.

@mui/xgrid should we remove api from the public API in v8 and just patch v7 to support proper types?

[cherniavskii]

This made api public API
We are not accessing api in any of our examples. People can use internal API, but that does not mean that we have to make it public.

Not sure what you mean here. api in this case is the same as apiRef.current, isn't it?

[arminmeh]

api in this case is the same as apiRef.current, isn't it

true, but we added another public point of accessing it.
I didn't deep dive into the initial issue where it was requested to document this, but I feel that we didn't had to.
Then we would also not have this "problem". And the proposed solution is that the developers still have to do some additional work, so it is just creating unnecessary complexity IMO

[arminmeh]

api was attached to the cell params because of https://github.com/mui/mui-x/blob/v7.23.5/packages/x-data-grid/src/components/cell/GridCell.tsx#L196
I don't think it was meant to be documented and part of the public API

[romgrk]

I think we should be removing api from the public API. We also expose our API as api is other places, that we should also remove.

[github-actions]

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

[github-actions]

Thanks for adding a type label to the PR! 👍

[github-actions]

Please add one type label to categorize the purpose of this PR appropriately:

bug, regression, enhancement, new feature, release or dependencies

[arminmeh]

Side Note: I'm not reexporting these types for pro and premium packages separately, one can pass pro and premium grid API in Api type param easily.

This creates a burden for the developers and I think that needs to be addressed before merging

[github-actions]

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

[github-actions]

This pull request has been closed due to 15 days of inactivity after being marked stale.