[charts] Refactor legend getters to use utility functions#21628
Draft
sai6855 wants to merge 13 commits intomui:masterfrom
Draft
[charts] Refactor legend getters to use utility functions#21628sai6855 wants to merge 13 commits intomui:masterfrom
sai6855 wants to merge 13 commits intomui:masterfrom
Conversation
sai6855
added
performance
plan: Pro
|
Deploy preview: https://deploy-preview-21628--material-ui-x.netlify.app/ Bundle size report
|
sai6855
added
the
type: enhancement
alexfauquette
approved these changes
Mar 5, 2026
github-actions
bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors legend item generation by extracting the shared logic into a new
getSeriesLegendItemsutility inlegendUtils.ts.BarChart,RangeBar,RadarChart, andScatterChartnow use this utility instead of duplicating the same logic, making the code cleaner and easier to maintain.The new
legendUtilsmodule is also exported through the internal index for use across the codebase.