[react] Support transpiled library for globalCss and keyframes#155
Merged
siriwatknp merged 2 commits intomasterfrom Jun 21, 2024
Merged
[react] Support transpiled library for globalCss and keyframes#155siriwatknp merged 2 commits intomasterfrom
globalCss and keyframes#155siriwatknp merged 2 commits intomasterfrom
Conversation
siriwatknp
commented
Jun 21, 2024
Comment on lines
+28
to
+30
| html { | ||
| color: red; | ||
| } |
Member
Author
There was a problem hiding this comment.
Without the change, this will not be generated.
brijeshb42
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this bug from mui/material-ui#42640
Root cause
The code of CssBaseline looks like this:
However, after building Material UI as a package and Next.js import it, the code before passing to Pigment is:
Notice that the value passed to
globalCssis a variable instead of a function. Pigment CSS thinks that it's not a function, that's why the CSS does not generated (with Emotion error):The fix is simple, we check the type after the evaluation and then pass the theme if it's a function.