[core] Fix thrown error during eval phase#196
Merged
brijeshb42 merged 1 commit intomui:masterfrom Aug 7, 2024
Merged
Conversation
This change changes the way we throw errors for our top-level exported functions. With the introduction of our build-time container components, we also started using the top-level APIs in these components. This in itself is ok since we don't want any restrictions. But this lead to an issue where an error was thrown, typically if trying to add sx prop on such container components (1 example). This was because these container component files were also being evaluated during the eval phase of wyw and that phase also included calls to generateAtomics which always throws error. So with this change, we first detect whether the function is being called during the eval phase or not, by checking a special global variable called `__wyw_dynamic_import` which is set by WyW before evaluation happens. So now these functions don't throw error during the eval stage.
siriwatknp
approved these changes
Aug 7, 2024
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
Thanks for the explanation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way we throw errors for our top-level exported functions. With the introduction of our build-time container components, we also started using the top-level APIs in these components. This in itself is ok since we don't want any restrictions. But this lead to an issue where an error was thrown, typically if trying to add sx prop on such container components (1 example).
This was because these container component files were also being evaluated during the eval phase of wyw and that phase also included calls to generateAtomics which always throws error. So with this change, we first detect whether the function is being called during the eval phase or not, by checking a special global variable called
__wyw_dynamic_importwhich is set by WyW before evaluation happens. So now these functions don't throw error during the eval stage.Fixes #193