FIX(client, ui): Don't display unsupported ACL#5768
Merged
Krzmbrzl merged 1 commit intomumble-voip:masterfrom Jul 31, 2022
Merged
FIX(client, ui): Don't display unsupported ACL#5768Krzmbrzl merged 1 commit intomumble-voip:masterfrom
Krzmbrzl merged 1 commit intomumble-voip:masterfrom
Conversation
If a recent client (1.4 or newer) was to connect to a pre-1.4 server and decide to edit a channel's ACL, the user would be presented with the option to configure the Listen ACL. However, since the server is too old to know about this particular ACL, setting it will have no effect. Thus, to the end user this creates the impression that something is broken. This commit ensures that the Listen ACL is only shown, if the server one is currently connected to, is recent enough to know about this ACL. Fixes mumble-voip#5692
davidebeatrici
approved these changes
Jul 31, 2022
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a recent client (1.4 or newer) was to connect to a pre-1.4 server and
decide to edit a channel's ACL, the user would be presented with the
option to configure the Listen ACL. However, since the server is too old
to know about this particular ACL, setting it will have no effect. Thus,
to the end user this creates the impression that something is broken.
This commit ensures that the Listen ACL is only shown, if the server one
is currently connected to, is recent enough to know about this ACL.
Fixes #5692
Checks