feat(LuaRenderer): native resizing support#583
Merged
Aurumaker72 merged 8 commits intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds native resize handling to the Lua rendering overlays so Lua script drawing surfaces track the main window size without forcing renderer recreation.
Changes:
- Extends the
Presenterinterface with aresize(D2D1_SIZE_U)API and wires it intoLuaRendereron main-windowSizeChangedevents. - Implements DComp presenter resizing by resizing swapchain buffers and rebuilding size-dependent resources.
- Removes the previous “destroy/recreate renderer on resize” behavior from the Lua GUI
ResizeWindowpath.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Views.Win32/lua/presenters/Presenter.h | Adds Presenter::resize() to support in-place resizing. |
| src/Views.Win32/lua/presenters/GDIPresenter.h | Declares GDIPresenter::resize() override. |
| src/Views.Win32/lua/presenters/GDIPresenter.cpp | Adds (currently empty) GDIPresenter::resize() implementation stub. |
| src/Views.Win32/lua/presenters/DCompPresenter.h | Adds resize()/size() ordering updates and stores HWND for DPI access. |
| src/Views.Win32/lua/presenters/DCompPresenter.cpp | Implements swapchain/resource resize path for DComp presenter. |
| src/Views.Win32/lua/modules/WGUI.h | Stops forcibly recreating the Lua renderer when resizing the main window. |
| src/Views.Win32/lua/LuaRenderer.cpp | Subscribes to SizeChanged, resizes overlay windows and backing surfaces, and forwards resize to the active presenter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua script drawing surfaces will now resize with the main window.