Cleanup bar line span properties#29603
Merged
cbjeukendrup merged 1 commit intomusescore:masterfrom Sep 26, 2025
Merged
Conversation
3bdef8c to
a9cd231
Compare
a9cd231 to
b2f7b99
Compare
cbjeukendrup
approved these changes
Sep 26, 2025
Collaborator
cbjeukendrup
left a comment
There was a problem hiding this comment.
Thanks! I thought I had already reviewed this, but apparently not. Better late than never!
They used to be integers in the pre-3.0 days, where a staff or bar line could specify that it spans multiple staves. This then got simplified to a bool, but this transition wasn't done cleanly. This commit makes up for that by making sure that we only work with booleans. int values are converted appropriately when reading pre-3.0 scores.
b2f7b99 to
172b53d
Compare
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They used to be integers in the pre-3.0 days, where a staff or bar line could specify that it spans multiple staves. This then got simplified to a bool, but this transition wasn't done cleanly. This commit makes up for that by making sure that we only work with booleans. int values are converted appropriately when reading pre-3.0 scores.
This gets rid of all property type mismatch log messages related to
spanandbarLineSpan.