Fix crash on removing bottom parentheses#32379
Merged
miiizen merged 11 commits intomusescore:4.7from Mar 2, 2026
Merged
Conversation
4 tasks
Contributor
|
I'm still seeing the issue, but now apparently involving the top note. Screen.Recording.2026-02-25.123304.mp4 |
miiizen
force-pushed
the
47ParensCrash
branch
from
59d78ec to
709daf9
Compare
Contributor
Author
|
@davidstephengrant this is ready for another review! |
Contributor
|
@miiizen Tested and approved on Windows 11 and Ubuntu 24.04.4 LTS. |
miiizen
force-pushed
the
47ParensCrash
branch
from
709daf9 to
28a6f6b
Compare
Previously, whenever this vector was modified addresses to its items could change. As we refer to these addresses in EditChord::removeChordParentheses, we need them to be stable.
miiizen
force-pushed
the
47ParensCrash
branch
from
28a6f6b to
8692204
Compare
mike-spa
approved these changes
Feb 27, 2026
The commands should do 2 things - forward requests to add/remove to chords and own NoteParenthesisInfo objects when they're on the undo stack.
miiizen
force-pushed
the
47ParensCrash
branch
2 times, most recently
from
2d7ebfd to
671e432
Compare
4 tasks
Contributor
|
@miiizen Tested and approved on Ubuntu 24.04.4 LTS. |
miiizen
added a commit
to miiizen/MuseScore
that referenced
this pull request
Mar 3, 2026
Fix crash on removing bottom parentheses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32367
At some point the order of the notes changed.