build: update Node.js to 20.12.0 for ARM64 support#321
Merged
justparking merged 64 commits intoMay 4, 2024
Conversation
- Migrate build scripts to be compatible - Bump Node.js version to one which supports ARM/Silicon builds - Configure the node-gradle-plugin
- Using `gradle wrapper` command
This reverts commit 058a407.
- 'default' includes googlefonts build, but the 'build' command does not
- This tackles a tiny regression which saw us lose -dev- handled in the generated .jar filename - We also handle the odd case of building in a git branch which includes a forward slash
- Configure Gradle build to include JUnit dependencies
- Cover SimpleNameTest with a couple of test cases - Ensure they pass
This reverts commit 9a23d63.
- Configure Gradle build to include JUnit dependencies
- Cover SimpleNameTest with a couple of test cases - Ensure they pass
… Actions and Events - These are in preparation for changes related to issue museumsvictoria#284
- Configure Gradle build to include JUnit dependencies
- Cover SimpleNameTest with a couple of test cases - Ensure they pass
…odel into feature/introduce-junit-testing # Conflicts: # nodel-framework/build.gradle # nodel-framework/src/test/java/org/nodel/SimpleNameTest.java
This reverts commit 1b9e15b.
justparking
reviewed
May 4, 2024
Collaborator
justparking
left a comment
justparking
left a comment
There was a problem hiding this comment.
All good. I haven't tried this on Windows yet. I wouldn't mind comparing the build times and size of builds (if any) between the different versions of node.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Node.js version to 20.12.0 in order to get access to ARM64 binaries for building on Apple Silicon machines.
ARM64 binaries were first introduced in Node.js 16+ but 20 and 18 are LTS.
Additionally, the
--legacy-peer-depsflag has been added to thenpmInstalltask, a new flag, which is necessary for ensuring compatibility with older dependencies that are otherwise forced to be updated.