Skip to content

Misc UI bug fixes#335

Merged
scroix merged 6 commits into
museumsvictoria:devfrom
mcartmel:dev
Aug 5, 2024
Merged

Misc UI bug fixes#335
scroix merged 6 commits into
museumsvictoria:devfrom
mcartmel:dev

Conversation

@mcartmel
Copy link
Copy Markdown
Collaborator

No description provided.

@justparking
Copy link
Copy Markdown
Collaborator

Hey @scroix and @thefennecdeer - do you mind doing a quick review of the changes in case you spot something that might cause an issue?

My only concern is this part:

// proactively disconnect websocket when the page is not being viewed

If it means it readily disconnects and reconnects the websocket, it might have a noticable effect flipping between browser tabs (and in particular, those hosting large dashboards/frontend). I know that the websocket code syncs up the state of all events every time it connects.

I've put this to @mcartmel already.

@scroix
Copy link
Copy Markdown
Member

scroix commented Jul 23, 2024

I'll take a look and report back 🫡

@scroix scroix self-requested a review July 23, 2024 11:12
@scroix
Copy link
Copy Markdown
Member

scroix commented Jul 31, 2024

No immediate issues with the dashboard updating across multiple devices/browsers, but I don't have the scale that @thefennecdeer would be dealing with.

@justparking, I did have a bit of trouble running the binary on Java 8. I can't recall whether we were enforcing Java 11 now. It might've just been my IDE settings overriding our Gradle rules for compatible builds.

@scroix scroix merged commit 71054c1 into museumsvictoria:dev Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants