feat: duplication dialog refinements#389
Open
scroix wants to merge 6 commits intomuseumsvictoria:devfrom
Open
Conversation
- Refine duplication dialog styling and layout - Make entire card header clickable for template deselection - Make node card body clickable to open source node - Simplify file filtering and ordering in duplicateNode
- Add LocalAutoDNS unit tests - Add template selection E2E and integration tests - Add multicast discovery smoke test - Document discovery test toggle in BUILDING.md
- Address PR review findings for LocalAutoDNS - Simplify buildHttpAddresses fallback return - Improve address resolution robustness
scroix
added
minor
Member
Author
|
This is based on some feedback from "The More You Node" '26 at ACMI. It blew up a little because I was determined to include automated test coverage to support the feature. |
|
@scroix the github email alerts to these updates don't do this justice, they dont elude there are video snippets!!! sooo freakin good.. this is the future ! Love your work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish to #373.
2026-01-30_Go0AYcRc.mp4
The duplication dialog now shows a proper selection card with the node's secondary info (descriptor, host) instead of just the name. Clicking the card body opens the source node in a new tab so you can inspect it before duplicating. Config copying is opt-in via checkbox, and auto-generated files (underscore-prefixed, script backups) are filtered out during copy.
967125566fe7529e54c8f588fc2d8468.webm
Also adds E2E tests for template selection using a new
LocalAutoDNSclass that enables deterministic discovery without multicast - useful for CI environments where multicast isn't available.