fix: avoid Unix-only process group handling on Windows#162
Open
Gujiassh wants to merge 1 commit intomvanhorn:mainfrom
Open
fix: avoid Unix-only process group handling on Windows#162Gujiassh wants to merge 1 commit intomvanhorn:mainfrom
Gujiassh wants to merge 1 commit intomvanhorn:mainfrom
Conversation
Use Windows-safe subprocess creation and timeout cleanup for yt-dlp search/transcript paths so Windows runs no longer crash on os.killpg or os.setsid. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Author
|
Quick check from my side: this branch is still clean locally and unchanged relative to its fork tracking branch ( Current state I rechecked today:
If this looks good on your end, it seems ready for review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.killpg()/os.setsidassumptions in the yt-dlp YouTube search and transcript pathsFixes #156.
Testing
python3 -m pytest tests/test_youtube_yt.py