Skip to content

fix(typing): Ensure LazyFrame has a unique TypeVar #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoGorelli merged 2 commits into from
Feb 4, 2025
Merged

fix(typing): Ensure LazyFrame has a unique TypeVar #1930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ec81f
fix(typing): Ensure `LazyFrame` has unique `TypeVar`
dangotbanned Feb 2, 2025
0e2449e
Merge remote-tracking branch 'upstream/main' into typing-lazyframe
dangotbanned Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion narwhals/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,13 @@

PS = ParamSpec("PS")

_FrameT = TypeVar("_FrameT", bound="IntoFrame")
FrameT = TypeVar("FrameT", bound="IntoFrame")
DataFrameT = TypeVar("DataFrameT", bound="IntoDataFrame")
R = TypeVar("R")


class BaseFrame(Generic[FrameT]):
class BaseFrame(Generic[_FrameT]):
_compliant_frame: Any
_level: Literal["full", "lazy", "interchange"]

Expand Down
Loading