feat!: require at least one expression be passed to lazyframe select and lazyframe.with_columns, remove lazyframe.clone#2206
Merged
MarcoGorelli merged 6 commits intonarwhals-dev:mainfrom Mar 15, 2025
Conversation
MarcoGorelli
force-pushed
the
lazyframe-strictness
branch
from
9b3d048 to
55a087e
Compare
Member
Author
|
discussed yesterday in the call, no objections |
MarcoGorelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2205
This doesn't break any downstream tests, and
narwhals.LazyFrameisn't widely used (yet 🤞 ) so I think it's OK to be slightly more aggressive with changes thereWe can always yank / revert if anyone complains and go through the usual process
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below