Merged
Conversation
FBruzzesi
reviewed
May 8, 2025
| from narwhals.utils import maybe_set_index | ||
|
|
||
| __version__ = "1.38.0" | ||
| __version__ = "1.38.1" |
Member
There was a problem hiding this comment.
Completely unrelated from this specific release but, should we use:
from importlib import metadata
__version__ = metadata.version(__name__)to simplify the sync with pyproject.toml?
Member
Author
There was a problem hiding this comment.
i remember there being some issue with importlib on older python versions, but if we're past those and don't require backports then sure 👍
FBruzzesi
reviewed
May 8, 2025
Comment on lines
30
to
34
| ```python | ||
| >>> import narwhals | ||
| >>> narwhals.__version__ | ||
| '1.38.0' | ||
| '1.38.1' | ||
| ``` |
Member
There was a problem hiding this comment.
This could also be automatically output as other python blocks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below