enh: deprecate nw.new_series in favour of Series.from_iterable#2642
Closed
MarcoGorelli wants to merge 6 commits intonarwhals-dev:mainfrom
Closed
enh: deprecate nw.new_series in favour of Series.from_iterable#2642MarcoGorelli wants to merge 6 commits intonarwhals-dev:mainfrom
nw.new_series in favour of Series.from_iterable#2642MarcoGorelli wants to merge 6 commits intonarwhals-dev:mainfrom
Conversation
Member
|
I thought that plan was At the very least, could we change the spelling to match where the term originated? |
Member
Author
|
yeah just struggling to think of a good name if |
nw.new_series in favour of Series.from_arraylikenw.new_series in favour of Series.from_iterable
Member
|
Hey @MarcoGorelli 👋 If you'd like, I could probably tick this one off of (#2116) pretty quickly by adapting (#2893)? I think the deprecation was the open question here - but I haven't been adding those in the other PRs |
Member
Author
|
sure, closing this one as stale / not planned, thanks! |
This was referenced Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below