refactor(expr-ir): Generate dispatch methods (wip)#3073
Merged
dangotbanned merged 4 commits intoexpr-ir/nw-namespacefrom Sep 1, 2025
Merged
refactor(expr-ir): Generate dispatch methods (wip)#3073dangotbanned merged 4 commits intoexpr-ir/nw-namespacefrom
dangotbanned merged 4 commits intoexpr-ir/nw-namespacefrom
Conversation
There might be a solution after building out the protocols more
#3068 was what started all this
10 tasks
dangotbanned
added a commit
that referenced
this pull request
Sep 1, 2025
Handled by #3073 **without** any other changes 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
ExprIR(main) #3066Checklist
If you have comments or can explain your changes, please do so below
Will eventually be replacing most of this (so far only
cast😄):narwhals/narwhals/_plan/protocols.py
Lines 149 to 200 in c72c3e4
And then something similar for this group as well:
narwhals/narwhals/_plan/protocols.py
Lines 201 to 222 in c72c3e4