Skip to content

perf(expr-ir): Optimize ExpansionFlags.from_ir #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangotbanned merged 1 commit into from
Oct 15, 2025
Merged

perf(expr-ir): Optimize ExpansionFlags.from_ir #3206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions narwhals/_plan/_expansion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,16 +130,17 @@ def from_ir(ir: ExprIR, /) -> ExpansionFlags:
has_selector: bool = False
has_exclude: bool = False
for e in ir.iter_left():
if isinstance(e, (Columns, IndexColumns)):
multiple_columns = True
elif isinstance(e, Nth):
has_nth = True
elif isinstance(e, All):
has_wildcard = True
elif isinstance(e, SelectorIR):
has_selector = True
elif isinstance(e, Exclude):
has_exclude = True
if isinstance(e, (_ColumnSelection, SelectorIR)):
if isinstance(e, (Columns, IndexColumns)):
multiple_columns = True
elif isinstance(e, Nth):
has_nth = True
elif isinstance(e, All):
has_wildcard = True
elif isinstance(e, SelectorIR):
has_selector = True
elif isinstance(e, Exclude):
has_exclude = True
return ExpansionFlags(
multiple_columns=multiple_columns,
has_nth=has_nth,
Expand Down
Loading